Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to verbose function anywhere in Datamaintain class #195

Open
nroulon opened this issue Sep 20, 2022 · 0 comments · May be fixed by #210
Open

Allow access to verbose function anywhere in Datamaintain class #195

nroulon opened this issue Sep 20, 2022 · 0 comments · May be fixed by #210
Assignees
@nroulon
Labels
refactoring

Comments

@nroulon
Copy link
Contributor

nroulon commented Sep 20, 2022

Currently, verbose and logger in general are lock in DatamaintainConfig (in context). The context class is not accessible from driver class (or other).

We need to allow it, maybe by configuring a specific logger or by set verbose and porcelain boolean into a static / thread local variable ?
nroulon added a commit that referenced this issue Feb 7, 2023
@nroulon
refactor: #195 verbose and porcelain are a cli feature and not in core
16c5aeb
nroulon added a commit that referenced this issue Feb 7, 2023
@nroulon
feat: #195 add option trace
6c51d7f
nroulon added a commit that referenced this issue Feb 7, 2023
@nroulon
refactor: #195 verbose and porcelain are a cli feature and not in core
aadfef6 
+ add option trace
@nroulon nroulon self-assigned this Feb 7, 2023
nroulon added a commit that referenced this issue Feb 7, 2023
@nroulon
refactor: #195 verbose and porcelain are a cli feature and not in core
922e2e2 
+ add option trace
@nroulon nroulon linked a pull request Feb 7, 2023 that will close this issue
Open
nroulon added a commit that referenced this issue May 2, 2023
@nroulon
feat: #195 move verbose and trace argument to App
3fc833a
nroulon added a commit that referenced this issue Jun 13, 2023
@nroulon
refactor: #195 verbose and porcelain are a cli feature and not in core
7e86daf 
+ add option trace
nroulon added a commit that referenced this issue Jun 13, 2023
@nroulon
feat: #195 move verbose and trace argument to App
3727703
nroulon added a commit that referenced this issue Jun 13, 2023
@nroulon
feat: #195 set -vv description in cli and docs
a39846a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nroulon nroulon

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: #195 verbose and porcelain are a cli feature and not in core 4sh/datamaintain
1 participant
@nroulon