Skip to content

Latest commit

 

History

History
183 lines (118 loc) · 6.96 KB

CONTRIBUTING.md

File metadata and controls

183 lines (118 loc) · 6.96 KB
Raw

Contributing to hypertrons-crx

It is warmly welcomed if you have interest to contribute to hypertrons-crx and help make it even better than it is today! The following is a set of guidelines for contributing to hypertrons-crx.

Code of Conduct

We have adopted a Code of Conduct to help us keep hypertrons-crx open and inclusive. Please read the full text so that you can understand what actions will and will not be tolerated.

Submitting an issue

If you have any questions or feature requests, please feel free to submit an issue.

Before you submit an issue, consider the following guidelines:

  • Please search for related issues. Make sure you are not going to open a duplicate issue.
  • Please specify what kind of issue it is and explain it in the title or content, e.g. feature, bug, documentation, discussion, help wanted... The issue will be tagged automatically by the robot of the project(Menbotics). See supported issue labels.

To make the issue details as standard as possible, we set up several issue templates for issue reporters. Please be sure to follow the instructions to fill fields in template.

There are a lot of cases when you could open an issue:

  • bug report
  • feature request
  • performance issues
  • feature design
  • help wanted
  • doc incomplete
  • test improvement
  • any questions on project
  • and so on

Also we must remind that when filling a new issue, please remember to remove the sensitive data from your post. Sensitive data could be password, secret key, network locations, private business data and so on.

Submitting a Pull Request

To help you get your feet wet and get you familiar with our contribution process, we have collected some good first issues that contain bugs or small features that have a relatively limited scope. This is a great place to get started.

Before you submit your Pull Request (PR), consider the following guidelines.

1. Claim an issue

Be sure that an issue describes the problem you're fixing, or documents the design for the feature you'd like to add.

If you decide to fix an issue, please be sure to check the comment thread in case somebody is already working on a fix. If nobody is working on it at the moment, please leave a comment with /self-assign stating that you intend to work on it so other people don't accidentally duplicate your effort. The robot of the project(Menbotics) will set assignees of the issue to yourself automatically.

/self-assign

If somebody claims an issue but doesn't follow up for more than two weeks, it's fine to take over it but you should still leave a comment.

2. Fork and clone the repository

Visit hypertrons/hypertrons-crx repo and make your own copy of the repository by forking it.

And clone your own copy of the repository to local, like :

# replace the XXX with your own user name
git clone git@github.com:XXX/hypertrons-crx.git
cd hypertrons-crx

4. Create a new branch

Create a new branch for development.

git checkout -b branch-name

The name of branch should be semantic, avoiding words like 'update' or 'tmp'. We suggest to use feature/xxx, if the modification is about to implement a new feature.

5. Make your changes

Now you can code. Please read and follow our Code Rules.

6. Commit your changes

Commit your changes If your changes pass the tests. You are encouraged to use angular commit-message-format to write commit message. In this way, we could have a more trackable history and an automatically generated changelog.

git add .
git commit -sm "fix: add license headers (#264)"

Husky and Prettier are adopted to automatically check code format on git commit (#386). If you are prompted with code style issues when a commit fails, please run yarn run prettier first then try to commit your changes again.

7. Sync your local repository with the upstream

Keep your local repository updated with upstream repository by:

git remote add upstream git@github.com:hypertrons/hypertrons-crx.git
git fetch upstream master
git rebase upstream/master

If conflicts arise, you need to resolve the conflicts manually, then:

git add my-fix-file
git rebase --continue

8. Push your branch to GitHub

git push -f origin branch-name

9. Create a Pull Request

In GitHub, send a pull request to hypertrons:hypertrons-crx.

Please sign our Contributor License Agreement (CLA) before sending PRs.

To make sure we can easily recap what happened previously, we have prepared a pull request template and you need to fill out the PR template. If you feel that some part of the template is redundant and your description is clear enough, you can just keep the necessary parts.

The core team is monitoring for pull requests. We will review your pull request and either merge it, request changes to it, or close it with an explanation.

If we suggest changes then:

  • Make the required updates.

  • Re-run the test to ensure tests are still passing.

  • Commit your changes with --amend and force push to your GitHub repository (this will update your Pull Request):

    git add .
git commit --amend
git push -f origin branch-name

That's it! Thank you for your contribution!

10. After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes from the upstream repository:

  • Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:

    git push origin --delete branch-name

  • Check out the master branch:

    git checkout master -f

  • Delete the local branch:

    git branch -D my-fix-branch

  • Update your master with the latest upstream version:

    git pull --ff upstream master

Signing the CLA

Please sign our Contributor License Agreement (CLA) before sending pull requests. For any code changes to be accepted, the CLA must be signed.